Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH PHP 8.2 support #10614

Merged
merged 1 commit into from
Dec 21, 2022
Merged

ENH PHP 8.2 support #10614

merged 1 commit into from
Dec 21, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 12, 2022 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Dec 12, 2022
Closed
3 tasks
@emteknetnz emteknetnz marked this pull request as draft December 12, 2022 23:12
@emteknetnz emteknetnz force-pushed the pulls/5/php82 branch 2 times, most recently from c1cc275 to b5b89b4 Compare December 14, 2022 02:07
@emteknetnz emteknetnz marked this pull request as ready for review December 14, 2022 02:24
GuySartorelli
GuySartorelli requested changes Dec 14, 2022
View reviewed changes
src/View/ViewableData.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/php82 branch 2 times, most recently from ba20b48 to 58ca434 Compare December 14, 2022 05:06
@emteknetnz emteknetnz marked this pull request as draft December 14, 2022 05:06
@emteknetnz emteknetnz force-pushed the pulls/5/php82 branch 3 times, most recently from e644ef7 to 78ed7fb Compare December 14, 2022 22:35
@emteknetnz emteknetnz force-pushed the pulls/5/php82 branch 3 times, most recently from f191595 to f7811ec Compare December 15, 2022 04:21
emteknetnz
emteknetnz commented Dec 15, 2022
View reviewed changes
src/ORM/DataObject.php Outdated Show resolved Hide resolved
emteknetnz
emteknetnz commented Dec 16, 2022
View reviewed changes
src/ORM/DataObject.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz marked this pull request as ready for review December 16, 2022 07:37
GuySartorelli
GuySartorelli requested changes Dec 19, 2022
View reviewed changes
src/ORM/DataObject.php Show resolved Hide resolved
src/ORM/DataObject.php Outdated Show resolved Hide resolved
src/ORM/DataObject.php Show resolved Hide resolved
src/ORM/FieldType/DBBoolean.php Outdated Show resolved Hide resolved
src/View/ViewableData_Customised.php Show resolved Hide resolved
@GuySartorelli GuySartorelli merged commit 5bf6835 into silverstripe:5 Dec 21, 2022
@GuySartorelli GuySartorelli deleted the pulls/5/php82 branch December 21, 2022 02:39
This was referenced Feb 27, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli